tag:blogger.com,1999:blog-2963790426029213933.post6448310120077091168..comments2024-02-29T00:33:07.382-08:00Comments on Alfred Chen's Blog: gc-branch update with CK's BFS 0463Alfred Chenhttp://www.blogger.com/profile/03164306846702841944noreply@blogger.comBlogger40125tag:blogger.com,1999:blog-2963790426029213933.post-91131339816393205402015-08-19T20:22:21.445-07:002015-08-19T20:22:21.445-07:00I really hope that you are able to find the "...I really hope that you are able to find the "final fix" ;-)<br /><br />Best wishes and always good luck,<br /><br />ManuelAnonymousnoreply@blogger.comtag:blogger.com,1999:blog-2963790426029213933.post-24890701924182503012015-08-18T09:27:43.818-07:002015-08-18T09:27:43.818-07:00@pf
Thanks for testing! At least it clear my suspi...@pf<br />Thanks for testing! At least it clear my suspicion in this code path. I'll find some time to look into other code path.<br /><br />BR AlfredAlfred Chenhttps://www.blogger.com/profile/03164306846702841944noreply@blogger.comtag:blogger.com,1999:blog-2963790426029213933.post-60029449490869052472015-08-18T09:09:19.140-07:002015-08-18T09:09:19.140-07:00Many thanks for your testing time! (Although it...Many thanks for your testing time! (Although it's sad news.)<br /><br />BR Manuel<br />Anonymousnoreply@blogger.comtag:blogger.com,1999:blog-2963790426029213933.post-79827794596013031252015-08-18T08:50:52.594-07:002015-08-18T08:50:52.594-07:00Alfred, unfortunately, your patch doesn't fix ...Alfred, unfortunately, your patch doesn't fix the issue. Got the same panic:<br /><br />https://drive.google.com/file/d/0BwjMKZtUByALYjJGNHF2T2VGc2M/view?usp=sharing<br /><br />Only CK fix seems to work OK now.Oleksandr Natalenkohttps://www.blogger.com/profile/12098091624630953604noreply@blogger.comtag:blogger.com,1999:blog-2963790426029213933.post-30988462519887466462015-08-17T10:26:40.152-07:002015-08-17T10:26:40.152-07:00@post-factum: I wish you happy testing! ;-) I'...@post-factum: I wish you happy testing! ;-) I've had it running for three days with -vrq without any related issues (that I haven't had anyway).<br /><br />BR ManuelAnonymousnoreply@blogger.comtag:blogger.com,1999:blog-2963790426029213933.post-2693154248097033022015-08-17T09:11:28.371-07:002015-08-17T09:11:28.371-07:00Reverted Con's patch, applied https://bitbucke...Reverted Con's patch, applied https://bitbucket.org/alfredchen/linux-gc/downloads/sched_submit_work.patch, rebooted OK. Waiting for… something.Oleksandr Natalenkohttps://www.blogger.com/profile/12098091624630953604noreply@blogger.comtag:blogger.com,1999:blog-2963790426029213933.post-19548648063147501402015-08-16T23:30:23.327-07:002015-08-16T23:30:23.327-07:00OK, as for now I may assume that CK fix did the tr...OK, as for now I may assume that CK fix did the trick, as my machine works well with it.<br /><br />Now I'm going to discard that patch and apply Alfred's one.Oleksandr Natalenkohttps://www.blogger.com/profile/12098091624630953604noreply@blogger.comtag:blogger.com,1999:blog-2963790426029213933.post-21555348528282579972015-08-14T16:36:22.642-07:002015-08-14T16:36:22.642-07:00I'm also testing it on top of -vrq atm, since ...I'm also testing it on top of -vrq atm, since you've published it. Just for you to get sure. No major issues so far with it in ~4h of uptime. My [i915] threw out two [Warning]s without it, now one [Error], but each without negative effects.<br /><br />I really hope, post-factum has a kind of timeframe in mind for the issue to materialize. ;-)<br /><br />Best regards to both of you,<br />Manuel KrauseAnonymousnoreply@blogger.comtag:blogger.com,1999:blog-2963790426029213933.post-32380904377875264672015-08-14T07:48:15.859-07:002015-08-14T07:48:15.859-07:00@pf
Would you plz try this path?
https://bitbucket...@pf<br />Would you plz try this path?<br />https://bitbucket.org/alfredchen/linux-gc/downloads/sched_submit_work.patchAlfred Chenhttps://www.blogger.com/profile/03164306846702841944noreply@blogger.comtag:blogger.com,1999:blog-2963790426029213933.post-6623873380885625872015-08-14T06:56:30.068-07:002015-08-14T06:56:30.068-07:00@Alfred, I cannot reproduce it reliably as it happ...@Alfred, I cannot reproduce it reliably as it happens under unknown circumstances for me. But it happens without patch and as for now doesn't happen with patch.<br /><br />Looks like race condition, but unfortunately I've got no idea what to do.Oleksandr Natalenkohttps://www.blogger.com/profile/12098091624630953604noreply@blogger.comtag:blogger.com,1999:blog-2963790426029213933.post-40522772791839620102015-08-14T06:09:23.913-07:002015-08-14T06:09:23.913-07:00In my opinion, that isn't the point. If the al...In my opinion, that isn't the point. If the algorithm fails at least once without the additional patch, there's something wrong with the code. So the question would rather be: Does the problem ever happen _with_ the patch?<br />A side question: What is so "bad" with the patched code?<br /><br />Best regards,<br />Manuel KrauseAnonymousnoreply@blogger.comtag:blogger.com,1999:blog-2963790426029213933.post-32681948550897267992015-08-14T05:12:25.637-07:002015-08-14T05:12:25.637-07:00@pf
Can it be 100% reproduced when you disable you...@pf<br />Can it be 100% reproduced when you disable your additional patch?Alfred Chenhttps://www.blogger.com/profile/03164306846702841944noreply@blogger.comtag:blogger.com,1999:blog-2963790426029213933.post-49135352741369216142015-08-14T00:25:53.601-07:002015-08-14T00:25:53.601-07:00Running OK as for now.Running OK as for now.Oleksandr Natalenkohttps://www.blogger.com/profile/12098091624630953604noreply@blogger.comtag:blogger.com,1999:blog-2963790426029213933.post-64395201961262131972015-08-13T19:15:40.854-07:002015-08-13T19:15:40.854-07:00@pf
I'll wait for your test result. Hopefully ...@pf<br />I'll wait for your test result. Hopefully can identify whether it is a btrfs issue or scheduler isssue.<br />Alfred Chenhttps://www.blogger.com/profile/03164306846702841944noreply@blogger.comtag:blogger.com,1999:blog-2963790426029213933.post-49242733127085107282015-08-12T23:31:15.002-07:002015-08-12T23:31:15.002-07:00I'm in doubt this is btrfs issue at all. Anywa...I'm in doubt this is btrfs issue at all. Anyway:<br /><br />===<br />pf@defiant:~ » cat /etc/fstab| grep btrfs<br />UUID=14140a7f-23bc-4dab-b263-f2f46f5d70aa / btrfs rw,relatime,space_cache 0 0<br />UUID=14140a7f-23bc-4dab-b263-f2f46f5d70aa /home btrfs rw,relatime,space_cache,subvol=@home 0 0<br />UUID=14140a7f-23bc-4dab-b263-f2f46f5d70aa /srv btrfs rw,relatime,space_cache,subvol=@srv 0 0<br />UUID=14140a7f-23bc-4dab-b263-f2f46f5d70aa /mnt/torrents btrfs rw,relatime,space_cache,subvol=@torrents 0 0<br />UUID=14140a7f-23bc-4dab-b263-f2f46f5d70aa /mnt/syncthing btrfs rw,relatime,space_cache,subvol=@syncthing 0 0<br />UUID=14140a7f-23bc-4dab-b263-f2f46f5d70aa /mnt/backups btrfs rw,relatime,space_cache,subvol=@backups 0 0<br />===<br /><br />===<br />pf@defiant:~ » lsblk<br />NAME MAJ:MIN RM SIZE RO TYPE MOUNTPOINT<br />sda 8:0 0 119.2G 0 disk <br />└─sda1 8:1 0 119.2G 0 part <br /> └─md127 9:127 0 119.2G 0 raid10 <br /> ├─base-boot 253:0 0 512M 0 lvm /boot<br /> └─base-system 253:1 0 118.7G 0 lvm <br /> └─system 253:2 0 118.7G 0 crypt <br /> ├─system-swap 253:3 0 8G 0 lvm [SWAP]<br /> └─system-root 253:4 0 110.7G 0 lvm /<br />sdb 8:16 0 119.2G 0 disk <br />└─sdb1 8:17 0 119.2G 0 part <br /> └─md127 9:127 0 119.2G 0 raid10 <br /> ├─base-boot 253:0 0 512M 0 lvm /boot<br /> └─base-system 253:1 0 118.7G 0 lvm <br /> └─system 253:2 0 118.7G 0 crypt <br /> ├─system-swap 253:3 0 8G 0 lvm [SWAP]<br /> └─system-root 253:4 0 110.7G 0 lvm /<br />sdc 8:32 1 57.7G 0 disk <br />└─md1 9:1 0 57.7G 0 raid10 /mnt/music<br />sdd 8:48 1 57.7G 0 disk <br />└─md1 9:1 0 57.7G 0 raid10 /mnt/music<br />===Oleksandr Natalenkohttps://www.blogger.com/profile/12098091624630953604noreply@blogger.comtag:blogger.com,1999:blog-2963790426029213933.post-66081174680027541852015-08-12T17:40:46.750-07:002015-08-12T17:40:46.750-07:00@pf, would you please share your btrfs setup(mount...@pf, would you please share your btrfs setup(mount options etc), I'll see if I can reproduce it myself.<br />And at the same time, let's see if your above patch works? And I am coming up with another patch to address this kind of issue.<br /><br />BR AlfredAlfred Chenhttps://www.blogger.com/profile/03164306846702841944noreply@blogger.comtag:blogger.com,1999:blog-2963790426029213933.post-22632101772011558722015-08-12T15:15:49.020-07:002015-08-12T15:15:49.020-07:00OK, booted with the following patch:
https://gith...OK, booted with the following patch:<br /><br />https://github.com/pfactum/pf-kernel/commit/044be9cd1fe06ffd00d4d6424729a88ebf497104<br /><br />Will test more.Oleksandr Natalenkohttps://www.blogger.com/profile/12098091624630953604noreply@blogger.comtag:blogger.com,1999:blog-2963790426029213933.post-56635568718842486642015-08-12T14:13:52.872-07:002015-08-12T14:13:52.872-07:00Too early to claim that, Manuel.
I've just en...Too early to claim that, Manuel.<br /><br />I've just encountered plug-related kernel panic on my home server with Btrfs.<br /><br />Screenshot 1: https://drive.google.com/file/d/0BwjMKZtUByALaXBiNWVLQWFqVFU/view?usp=sharing<br /><br />Screenshot 2: https://drive.google.com/file/d/0BwjMKZtUByALNUNVcUhSeV9XNnc/view?usp=sharing<br /><br />Will try to adapt CK fix attempt to -gc branch.Oleksandr Natalenkohttps://www.blogger.com/profile/12098091624630953604noreply@blogger.comtag:blogger.com,1999:blog-2963790426029213933.post-29746322527918534582015-08-12T11:57:03.224-07:002015-08-12T11:57:03.224-07:00Maybe "someone" ;-) will realize in som...Maybe "someone" ;-) will realize in some near future, that your, Alfred's, code improvements to BFS are that comprehensive and useful that he'd adopt them and make fixing with such an "old" hack solution superfluous/ unnecessary. I'm content with the results of your recent heavy work.<br /><br />Any news from kernelOfTruth in the meantime?<br /><br />BR ManuelAnonymousnoreply@blogger.comtag:blogger.com,1999:blog-2963790426029213933.post-83632186708462280672015-08-10T01:17:21.495-07:002015-08-10T01:17:21.495-07:00As I know, kernelOfTruth has "btrfs scrub&quo...As I know, kernelOfTruth has "btrfs scrub" issue but his "trial fix" which similar to CK's reverse-unpluggged patch doesn't look helping. I have sent email to him and ask how his issue going.<br /><br />For these unplugged io code changes, I'd like to keep it sync with mainline code at this moment, if it's confirmed it causes issues then we found solution to fix it.<br /><br />BR AlfredAlfred Chenhttps://www.blogger.com/profile/03164306846702841944noreply@blogger.comtag:blogger.com,1999:blog-2963790426029213933.post-88328058654791646172015-08-09T23:12:42.769-07:002015-08-09T23:12:42.769-07:00Alfred, there are no reports regarding Btrfs as fa...Alfred, there are no reports regarding Btrfs as far as I remember. I'm unable to reproduce the issue for now as I do not use Btrfs (if it is Btrfs-related at all).<br /><br />Anyway, if there some report happens, I'll forward it to you.Oleksandr Natalenkohttps://www.blogger.com/profile/12098091624630953604noreply@blogger.comtag:blogger.com,1999:blog-2963790426029213933.post-49060805322641503162015-08-09T12:35:25.268-07:002015-08-09T12:35:25.268-07:00Just for the records, I've found a related ref...Just for the records, I've found a related reference in this directory, at least: http://ck.kolivas.org/patches/bfs/3.0/3.18/pending/ The patch is "bfs460-locked-pluggedio.patch". Funny, to realize the date... 31-Dec-2014.<br /><br />From your programmers' point of view, would you say the revert of the newer plugged I/O code would slow down the kernel? I'm a bit astonished, that the code is in CFS as well (or based on it,) and we haven't seen complaints from that people.<br /><br />BR, Manuel KrauseAnonymousnoreply@blogger.comtag:blogger.com,1999:blog-2963790426029213933.post-10472842847684870012015-08-09T12:11:13.173-07:002015-08-09T12:11:13.173-07:00That's a really good point, Alfred, to ask for...That's a really good point, Alfred, to ask for pf-kernel users' experience. I'm watching the pf-kernel forum, but can't see any specific failure report for this. Maybe I've overlooked something especially regarding older kernels, in which Con also had to revert the plugged I/O code. I'm not sure, what previous/ maybe deprecated kernel it exactly was.<br />And now again: Are you both, including you, Oleksandr, able to reproduce the issue? And if yes, how do I get it on here, too? I'm currently fine with the renewed -vrq branch, but have to admit, that I'm not making heavy use of transfers to external exchangable media.<br /><br />Best regards, and thank you both for your valuable and appreciated work,<br />Manuel KrauseAnonymousnoreply@blogger.comtag:blogger.com,1999:blog-2963790426029213933.post-63910754986479259482015-08-09T07:20:09.128-07:002015-08-09T07:20:09.128-07:00You can try this https://bitbucket.org/alfredchen/...You can try this https://bitbucket.org/alfredchen/linux-gc/downloads/4.1_0463_1_revert_unplugged.patch<br /><br />I am still watching whether to use this patch or not, no similar issues are reported when using gc branch. I last untar files to tf card turns out to be a btrfs fs corruption.<br /><br />@pf, any similar report from usr pf-kernel users?<br /><br />BR AlfredAlfred Chenhttps://www.blogger.com/profile/03164306846702841944noreply@blogger.comtag:blogger.com,1999:blog-2963790426029213933.post-7884470667615365182015-08-09T04:44:31.300-07:002015-08-09T04:44:31.300-07:00Here is the patch accepted by CK:
https://gist.gi...Here is the patch accepted by CK:<br /><br />https://gist.github.com/2917ffd222e8b100ffd3<br /><br />It cannot be applied to -gc in current form but may be adopted. Alfred?Oleksandr Natalenkohttps://www.blogger.com/profile/12098091624630953604noreply@blogger.com